[Bug 704070] video: Add Region Of Interest (roi) meta

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704070
  GStreamer | gst-plugins-base | 1.x

--- Comment #12 from Miguel (elmiguelao) Casas-Sanchez <miguelecasassanchez at gmail.com> 2013-07-16 07:16:57 UTC ---
(In reply to comment #11)
> Review of attachment 249212 [details]:
> 
> Almost :)
> 
> ::: gst-libs/gst/video/gstvideometa.c
> @@ +1,1 @@
> +/*
> 
> Why did you remove this? :)
> 

Oops, well let me blame the tool, I changed emacs with sublime and C-x C-s
turns into: delete line, save :)

> @@ +536,3 @@
> +{
> +  static volatile GType type;
> +  static const gchar *tags[] = { "location", " size", NULL };
> 
> This should be orientation and size, location has no meaning yet. What do you
> mean with location here?
> 

I understood
x,y -> location of the roi (anchor point)
w,h -> size of the roi

> @@ +594,3 @@
> +{
> +  GstVideoRegionOfInterestMeta *emeta = (GstVideoRegionOfInterestMeta *) meta;
> +  emeta->x = emeta->y = emeta->w = emeta->h = 0;
> 
> Initialize the other fields too

Done.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.