[Bug 691712] [API] codecparsers: add GstMetas to pass parsing results downstream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=691712
  GStreamer | gst-plugins-bad | git

--- Comment #20 from Gwenole Beauchesne <gb.devel at gmail.com> 2013-07-18 17:38:59 UTC ---
Review of attachment 249503:
 --> (https://bugzilla.gnome.org/review?bug=691712&attachment=249503)

Hi, I would prefer the GArray be an array of GstMpegVideoSliceInfo elements,
not pointers to GstMpegVideoSliceInfo structs.

::: gst-libs/gst/codecparsers/gstmpegvideometa.c
@@ +124,3 @@
+    slice_info_src =
+        g_array_index (slice_info_array, GstMpegVideoMetaSliceInfo *, i);
+    slice_info_dst = g_slice_dup (GstMpegVideoMetaSliceInfo, slice_info_src);

A GArray of pointers is called a GPtrArray. :)

@@ +128,3 @@
+  }
+}
+

I would rename gst_mpeg_video_meta_add_slice_info() to
gst_mpeg_video_meta_set_slice_info() and simply g_array_ref() the slice_info
there.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.