[Bug 691712] [API] codecparsers: add GstMetas to pass parsing results downstream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=691712
  GStreamer | gst-plugins-bad | git

--- Comment #21 from Gwenole Beauchesne <gb.devel at gmail.com> 2013-07-18 17:42:48 UTC ---
Review of attachment 249504:
 --> (https://bugzilla.gnome.org/review?bug=691712&attachment=249504)

I think it's possible to use GstMpegVideoSliceInfo elements as is, instead of
allocating and storing pointers to thoat struct. At least, this is what I would
like to have, so that to avoid too many dynamic allocations. :)

::: gst/videoparsers/gstmpegvideoparse.c
@@ +636,3 @@
+    slice_info->slice_size = (off - 4) - mpvparse->slice_offset;
+    g_array_append_val (mpvparse->slice_info_array, slice_info);
+

Can't we just g_array_set_size() +
{
  GstMpegVideoMetaSliceInfo * const slice_info =
    &g_array_index(mpvparse->slice_info_array, GstMpegVideoMetaSliceInfo, i);
  and directly parse_slice_header() in there?
}

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.