[Bug 701513] New: x264 encoder plugins uses uninitialised frame number

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701513
  GStreamer | gst-plugins-ugly | 1.0.7

           Summary: x264 encoder plugins uses uninitialised frame number
    Classification: Platform
           Product: GStreamer
           Version: 1.0.7
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: blocker
          Priority: Normal
         Component: gst-plugins-ugly
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: bilvanavathe at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


In gstx264enc.c :
function : gst_x264_enc_encode_frame()
a local variable is defined :

x264_picture_t pic_out;

After this definition, pic_out is passed to x264 encoder :

encoder_return = x264_encoder_encode (encoder->x264enc,
      &nal, i_nal, pic_in, &pic_out);

After this, pic_out is used is following line :

 frame = gst_video_encoder_get_frame (GST_VIDEO_ENCODER (encoder),
      GPOINTER_TO_INT (pic_out.opaque));

The X264 encoder doesn't touch the opaque data structure, so it remains
uninitialised.
So, why are we trying to extract frame number from the uninitialised "opaque"
member of pic_out?

It gives some garbage number.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.