[Bug 701513] x264 encoder plugins uses uninitialised frame number

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=701513
  GStreamer | gst-plugins-ugly | 1.0.7

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.dufresne at collabora.
                   |                            |co.uk

--- Comment #1 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2013-06-03 15:28:00 UTC ---
(In reply to comment #0)
> The X264 encoder doesn't touch the opaque data structure, so it remains
> uninitialised.
> So, why are we trying to extract frame number from the uninitialised "opaque"
> member of pic_out?

x264_encoder_encode() is suppose to copy the opaque_pointer from the origin
input structure. I've fixed this bug once in 0.10, so I'm wondering why we get
that again. Last time, libx264 was at fault, so be increased the minmum
required version.

The opaque pointer should always be initialize in the first place. This frame
number is to match with locally stored frames (thus timestamps). The encoder do
reordering, this is the reason we need that ID dance. Bug #701517 is most
likely a duplicate.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.