[Bug 686459] pulsesink: playbin uri=x.mp3 audio-sink='identity ! pulsesink' => not-negotiated flow error

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=686459
  GStreamer | gst-plugins-good | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246160|none                        |needs-work
             status|                            |

--- Comment #13 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-06 14:15:17 UTC ---
Review of attachment 246160:
 --> (https://bugzilla.gnome.org/review?bug=686459&attachment=246160)

Looks good, can be pushed after fixing the second comment and if you think
nothing else is missing

::: ext/pulse/pulsesink.c
@@ +2053,3 @@
+    gst_caps_set_simple (ret, "channels", G_TYPE_INT, channels, NULL);
+
+  /* FIXME: add channel map */

What's missing to implement that?

@@ +2222,3 @@

+  pad_caps = gst_pad_get_pad_template_caps (GST_BASE_SINK_PAD (psink));
+  ret = gst_caps_can_intersect (pad_caps, caps);

Should be gst_caps_is_subset(caps, pad_caps)

@@ +2300,3 @@
   } else {
     /* We're in READY, let's connect a stream to see if the format is
+     * accepted by whatever sink we're routed to */

Even fixed a typo ;)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.