[Bug 701953] New: [PATCH] gstwrappercamerabinsrc: Add video-source-filter during construction

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Jun 10 11:07:25 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=701953
  GStreamer | gst-plugins-bad | unspecified

           Summary: [PATCH] gstwrappercamerabinsrc: Add
                    video-source-filter during construction
    Classification: Platform
           Product: GStreamer
           Version: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: jwrdegoede at fedoraproject.org
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=246425)
 View: https://bugzilla.gnome.org/attachment.cgi?id=246425
 Review: https://bugzilla.gnome.org/review?bug=701953&attachment=246425

[PATCH] gstwrappercamerabinsrc: Add video-source-filter during construction

By adding the video-source-filter during construction time, rather then
patching it in later (*), we can avoid a potentially expensive renegotiation
later on. And if the video-source-filter also reduces the video-source
caps, we also greatly reduce the amount of caps involved
in negotiation, speeding up pipeline creation further.

I wrote this while working on speeding up the startup of cheese. My cheese
has been modified to add a capsfilter, filtering for only the configured
resolution, with that cheese patch + this patch, the pipeline creation time
goes from aprox 1.1 seconds to aprox 350ms. This is with a Logitech 9000
pro camera, which supports lots of different resolutions at many different
framerates per resolution, causing a caps "explosion" if not filtered.

*) Note the code for this is left in, as it is still necessary if the
video-source-filter is changed between a stop + re-start.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list