[Bug 701953] [PATCH] gstwrappercamerabinsrc: Add video-source-filter during construction

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Jun 11 03:49:17 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=701953
  GStreamer | gst-plugins-bad | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |slomo at circular-chaos.org
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.1.2

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2013-06-11 10:49:13 UTC ---
It might make sense to use gst_caps_simplify() in the source to make the caps a
bit smaller (note that it causes the caps order to change). Also a capsfilter
from the application definitely makes sense if you have restrictions from the
app anyway.

commit 28e64d10312d9df97ba609ee9ca871595fff8db2
Author: Hans de Goede <hdegoede at redhat.com>
Date:   Mon Jun 10 17:00:42 2013 +0200

    wrappercamerabinsrc: Add video-source-filter during construction

    By adding the video-source-filter during construction time, rather then
    patching it in later (*), we can greatly reduce the amount of caps involved
    in negotation, speeding up pipeline creation.

    I wrote this while working on speeding up the startup of cheese. My cheese
    has been modified to add a capsfilter, filtering for only the configured
    resolution, with that cheese patch + this patch, the pipeline creation time
    goes from aprox 1.1 seconds to aprox 350ms. This is with a Logitech 9000
    pro camera, which supports lots of different resolutions at many different
    framerates per resolution, causing a caps "explosion" if not filtered.

    *) Note the code for this is left in, as it is still necessary if the
    video-source-filter is changed between a stop + re-start.

    https://bugzilla.gnome.org/show_bug.cgi?id=701953

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list