[Bug 705991] Adding support for DASH common encryption to qtdemux and dashdemux

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705991
  GStreamer | gst-plugins-good | git

Chris Bass <floobleflam> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |floobleflam at gmail.com

--- Comment #11 from Chris Bass <floobleflam at gmail.com> 2013-11-06 09:07:32 UTC ---
(In reply to comment #9)

Thanks for the comments, Sebastian. Could you clarify a couple of things:

[...]
> @@ +37,3 @@
> + * Holds information about a subsample of a cenc-protected sample.
> + */
> +struct _CencSubsampleInfo
> 
> SubSample maybe?

Are you suggesting calling it GstCencSubSampleInfo or GstCencSubSample?

> @@ +57,3 @@
> +  GBytes *iv;
> +  guint16 n_subsamples;
> +  GArray *subsample_info;
> 
> These should probably all get boxed types and ref/unref functions at least.
> Maybe make them miniobjects? Also some padding in the structs might be sensible
> :)

Do you mean that you think all of the typedef'd structs in cenc.h
(GstCencSampleProperties/GstCencSampleCryptoInfo/GstCencSubSampleInfo) should
be made into boxed types?

[...]

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.