[Bug 705991] Adding support for DASH common encryption to qtdemux and dashdemux

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705991
  GStreamer | gst-plugins-good | git

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-06 09:34:10 UTC ---
(In reply to comment #11)

> > @@ +37,3 @@
> > + * Holds information about a subsample of a cenc-protected sample.
> > + */
> > +struct _CencSubsampleInfo
> > 
> > SubSample maybe?
> 
> Are you suggesting calling it GstCencSubSampleInfo or GstCencSubSample?

GstCencSubSampleInfo, I just meant the upper-case S for sample :) Seems more
consistent with everything else.

> > @@ +57,3 @@
> > +  GBytes *iv;
> > +  guint16 n_subsamples;
> > +  GArray *subsample_info;
> > 
> > These should probably all get boxed types and ref/unref functions at least.
> > Maybe make them miniobjects? Also some padding in the structs might be sensible
> > :)
> 
> Do you mean that you think all of the typedef'd structs in cenc.h
> (GstCencSampleProperties/GstCencSampleCryptoInfo/GstCencSubSampleInfo) should
> be made into boxed types?

Yes, as those structures are public API and inside a library it must be
possible to use them from bindings. And GObjectIntrospection wants boxed types
for them.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.