[Bug 671136] mpegtsmux: add support for SDT and NIT tables for DVB-S/DVB-T

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=671136
  GStreamer | gst-plugins-bad | git

--- Comment #32 from Edward Hervey <bilboed at bilboed.com> 2013-11-15 15:17:42 UTC ---
Review of attachment 258649:
 --> (https://bugzilla.gnome.org/review?bug=671136&attachment=258649)

::: gst/mpegtsmux/mpegtsmux.c
@@ +284,3 @@
+  g_object_class_install_property (G_OBJECT_CLASS (klass), ARG_SI_INTERVAL,
+      g_param_spec_uint ("si-interval", "SI interval",
+          "Set the interval (in ticks of the 90kHz clock) for writing out the
Service"

Just wondering if it wouldn't be more user friendly to have that in
GstClockTime

@@ +1713,3 @@
+    /* TODO: Implement other section types */
+    if (GST_MPEGTS_SECTION_TYPE (section) == GST_MPEGTS_SECTION_NIT)
+      tsmux_add_mpegts_si_section (mux->tsmux, section);

is the reference transfer properly handled here ?

@@ +1717,3 @@
+    return TRUE;
+  }
+

Don't forget to unref the event :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.