[Bug 727560] mpegts: add frequency list, scrambling and dvb ca indentifier descriptor

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727560
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273543|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-04-04 07:51:58 UTC ---
Review of attachment 273543:
 --> (https://bugzilla.gnome.org/review?bug=727560&attachment=273543)

::: gst-libs/gst/mpegts/gst-dvb-descriptor.c
@@ +1254,3 @@
+
+  if (type == 1) {
+    // satellite

Don't use C99 comments

@@ +1265,3 @@
+  len = descriptor->length - 1;
+
+  for (guint8 i = 0; i < len; i += 4) {

If I'm not missing anything this could read over the end of the byte array. It
should be i < len - 3

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.