[Bug 727560] mpegts: add frequency list, scrambling and dvb ca indentifier descriptor

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727560
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273545|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-04-04 07:53:01 UTC ---
Review of attachment 273545:
 --> (https://bugzilla.gnome.org/review?bug=727560&attachment=273545)

::: gst-libs/gst/mpegts/gst-dvb-descriptor.c
@@ +915,3 @@
+  __common_desc_checks (descriptor, GST_MTS_DESC_DVB_CA_IDENTIFIER, 2, FALSE);
+
+  data = (guint8 *) descriptor->data + 2;

What's in the first two bytes?

@@ +919,3 @@
+  *list = g_array_new (FALSE, FALSE, sizeof (guint16));
+
+  for (guint i = 0; i < descriptor->length; i += 2) {

Same as in the other one, i < descriptor->length - 1. Probably more of these
things in the already existing code.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.