[Bug 727460] mpegts: add atsc terrestrial virtual channel table

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727460
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273431|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-04-04 08:02:24 UTC ---
Review of attachment 273431:
 --> (https://bugzilla.gnome.org/review?bug=727460&attachment=273431)

::: gst-libs/gst/mpegts/gst-atsc-section.c
@@ +3,3 @@
+ *
+ * Authors:
+ *   Edward Hervey <edward at collabora.com>

I think that copyright notice here is wrong :)

@@ +96,3 @@
+
+  /* Skip already parsed data */
+  data += 8;

You should check sizes here imho

@@ +109,3 @@
+  for (guint i = 0; i < source_nb; i++) {
+    GstMpegTsAtscTVCTSource *source;
+

And inside the loop, or in front of the loop for the complete loop too

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.