[Bug 727460] mpegts: add atsc terrestrial virtual channel table

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727460
  GStreamer | gst-plugins-bad | git

--- Comment #3 from Stefan Ringel <mail at stefanringel.de> 2014-04-04 09:20:09 UTC ---
(In reply to comment #2)
> Review of attachment 273431 [details]:
> 
> ::: gst-libs/gst/mpegts/gst-atsc-section.c
> @@ +3,3 @@
> + *
> + * Authors:
> + *   Edward Hervey <edward at collabora.com>
> 
> I think that copyright notice here is wrong :)
you right, I have overseen.
> 
> @@ +96,3 @@
> +
> +  /* Skip already parsed data */
> +  data += 8;
> 
> You should check sizes here imho
I don't know how many bytes it has. I can only check a minimum.
> 
> @@ +109,3 @@
> +  for (guint i = 0; i < source_nb; i++) {
> +    GstMpegTsAtscTVCTSource *source;
> +
> 
> And inside the loop, or in front of the loop for the complete loop too

The same like above. But we have a number of entries (source_nb).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.