[Bug 726299] avvideodec: Should reject buffer pools that cannot grow

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726299
  GStreamer | gst-libav | 1.2.3

--- Comment #8 from Jian Li <lj.qfy.sh at gmail.com> 2014-04-08 03:07:37 UTC ---
(In reply to comment #6)
Shall it also reject the allocator, actually the pool can't grow as the
allocator can't allocate more.

The patch should be updated as:

  /* Don't use pool that can't grow, as we don't know how many buffer we'll
   * need, otherwise we may stall */
  if (max != 0) {
    gst_object_unref (pool);
    pool = gst_video_buffer_pool_new ();
+    gst_object_unref (allocator);
+    allocator = NULL;
    max = 0;
    update_pool = TRUE;
  }


> Created an attachment (id=273126)
 View: https://bugzilla.gnome.org/attachment.cgi?id=273126
 Review: https://bugzilla.gnome.org/review?bug=726299&attachment=273126

> [PATCH] videodec: Don't use non-growable pool
> 
> 
> As we don't know how many output buffer we need to operate, we need to
> avoid pool that can't grow. Otherwise the pipeline may stall, waiting
> for buffers.
> 
> https://bugzilla.gnome.org/show_bug.cgi?id=726299
> ---
>  ext/libav/gstavviddec.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.