[Bug 726299] avvideodec: Should reject buffer pools that cannot grow

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726299
  GStreamer | gst-libav | 1.2.3

--- Comment #9 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-04-19 02:43:47 UTC ---
(In reply to comment #8)
> (In reply to comment #6)
> Shall it also reject the allocator, actually the pool can't grow as the
> allocator can't allocate more.
> 
> The patch should be updated as:
> 
>   /* Don't use pool that can't grow, as we don't know how many buffer we'll
>    * need, otherwise we may stall */
>   if (max != 0) {
>     gst_object_unref (pool);
>     pool = gst_video_buffer_pool_new ();
> +    gst_object_unref (allocator);
> +    allocator = NULL;
>     max = 0;
>     update_pool = TRUE;
>   }

I totally agree, thanks for pointing this out.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.