[Bug 734716] bus: signal watched added in a new thread-default context can't be removed

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Aug 13 08:41:39 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=734716
  GStreamer | gstreamer (core) | git

Philippe Normand <phil> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #283291|0                           |1
        is obsolete|                            |

--- Comment #8 from Philippe Normand <phil at base-art.net> 2014-08-13 15:41:35 UTC ---
Created an attachment (id=283296)
 View: https://bugzilla.gnome.org/attachment.cgi?id=283296
 Review: https://bugzilla.gnome.org/review?bug=734716&attachment=283296

bus: destroy signal watch from the context it was mapped to

Don't rely on g_source_remove() because it operates on the main
context. If a signal watch was added to a new thread-default context
g_source_remove() would have no effect. So simply use
g_source_destroy() to avoid this problem.

Additionally the source_id was removed from GstBusPrivate because it
was redundant with the signal watch GSource also stored in that
structure.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list