[Bug 734716] bus: signal watched added in a new thread-default context can't be removed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=734716
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.5.1

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-08-13 15:46:46 UTC ---
commit b1f23598099da82835df60bc2fb09501233f9118
Author: Philippe Normand <philn at igalia.com>
Date:   Wed Aug 13 14:12:00 2014 +0200

    bus: destroy signal watch from the context it was mapped to

    Don't rely on g_source_remove() because it operates on the main
    context. If a signal watch was added to a new thread-default context
    g_source_remove() would have no effect. So simply use
    g_source_destroy() to avoid this problem.

    Additionally the source_id was removed from GstBusPrivate because it
    was redundant with the signal watch GSource also stored in that
    structure.

    https://bugzilla.gnome.org/show_bug.cgi?id=734716

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.