[Bug 720692] audioringbuffer: track last position across release/acquire

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Jan 3 02:55:46 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=720692
  GStreamer | gst-plugins-base | unspecified

--- Comment #4 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2014-01-03 10:55:43 UTC ---
> > This contains time for some time, and samples the remaining time. Please use
> > two different variables to make this clear and also mark the values as invalid
> > when they should not be used anymore
> 
> OK, fixed

It does eat 8 more bytes off the reserved space though. 24 bytes altogether.
I'm just thinking I could make the time and sample bases a union, since their
scope do not overlap. This would make them still use the same storage, but be
"logically" different for clarity. Would you be OK with that, or do you think
it's not worth it ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list