[Bug 720692] audioringbuffer: track last position across release/acquire

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Jan 3 02:57:32 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=720692
  GStreamer | gst-plugins-base | unspecified

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-03 10:57:24 UTC ---
(In reply to comment #2)
> Thanks for reviewing,
> 
> > This contains time for some time, and samples the remaining time. Please use
> > two different variables to make this clear and also mark the values as invalid
> > when they should not be used anymore
> 
> OK, fixed

You still store time or samples in the same variable. Please don't and use two
variables for that :) After acquire() it is samples, after release() it is
time.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list