[Bug 720597] decodebin: query allocation always sent twice

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720597
  GStreamer | gst-plugins-base | 1.2.1

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265734|none                        |accepted-commit_now
             status|                            |

--- Comment #22 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-08 19:06:09 UTC ---
Review of attachment 265734:
 --> (https://bugzilla.gnome.org/review?bug=720597&attachment=265734)

Generally good, just fix the comments and push. And please do the same for the
other 3 base classes :)

::: gst-libs/gst/video/gstvideodecoder.c
@@ +3115,3 @@
   query = gst_query_new_allocation (caps, TRUE);

+  GST_DEBUG_OBJECT (decoder, "DO query ALLOCATION");

Maybe don't scream "DO" :)

@@ +3155,2 @@
   if (decoder->priv->pool) {
+    GST_DEBUG_OBJECT (decoder, "inactivate pool %" GST_PTR_FORMAT,

deactivate?

@@ +3242,2 @@
     ret = TRUE;
+    GST_DEBUG_OBJECT (decoder, "previous caps and state caps are the same");

...and *output* state caps...

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.