[Bug 720597] decodebin: query allocation always sent twice

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720597
  GStreamer | gst-plugins-base | 1.2.1

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265736|none                        |needs-work
             status|                            |

--- Comment #23 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-08 19:09:09 UTC ---
Review of attachment 265736:
 --> (https://bugzilla.gnome.org/review?bug=720597&attachment=265736)

Why so complicated? Please simplify the code and also don't store the counter
in the instance :)

Should be possible to just do something like:

negotiate() {
  if (!reconfigure) return;

  x = 0;
  while (x < NUM) {
    negotiate_caps();
    if (reconfigure) continue;
    negotiate_pool();
    if (reconfigure) continue;
  }
}

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.