[Bug 722705] Factor out common init/reset code from matroska parse/demux

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722705
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266890|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-22 09:05:48 UTC ---
Review of attachment 266890:
 --> (https://bugzilla.gnome.org/review?bug=722705&attachment=266890)

::: gst/matroska/matroska-demux.c
@@ +190,3 @@
   GstMatroskaDemux *demux = GST_MATROSKA_DEMUX (object);

+  gst_matroska_read_common_finalize_ctx (&demux->common);

It's called GstMatroskaReadCommon, not GstMatroskaReadCommonCtx

@@ -197,3 @@
-  if (demux->common.global_tags) {
-    gst_tag_list_unref (demux->common.global_tags);
-    demux->common.global_tags = NULL;

I think the tags and the ptr array should be emptied in reset() already but
that's not a bug in your patch

::: gst/matroska/matroska-read-common.c
@@ +2859,3 @@
+
+void
+gst_matroska_read_common_reset_ctx (GstElement * element,

I assume you made sure you copied everything over from the other two reset
functions here? At least the index stuff is missing, but that can and should
disappear anyway.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.