[Bug 722705] Factor out common init/reset code from matroska parse/demux

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722705
  GStreamer | gst-plugins-good | git

--- Comment #3 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> 2014-01-30 22:38:59 UTC ---
(In reply to comment #2)
> Review of attachment 266890 [details]:
> 
> ::: gst/matroska/matroska-demux.c
> @@ +190,3 @@
>    GstMatroskaDemux *demux = GST_MATROSKA_DEMUX (object);
> 
> +  gst_matroska_read_common_finalize_ctx (&demux->common);
> 
> It's called GstMatroskaReadCommon, not GstMatroskaReadCommonCtx

Yeah, figured out _ctx made more sense for these funcs but
renamed them in the latest patch.

> [...]
> ::: gst/matroska/matroska-read-common.c
> @@ +2859,3 @@
> +
> +void
> +gst_matroska_read_common_reset_ctx (GstElement * element,
> 
> I assume you made sure you copied everything over from the other two reset
> functions here? At least the index stuff is missing, but that can and should
> disappear anyway.

You mean the element_index stuff? That code was disabled
already so I just dropped it. As per the rest as far as
I can see everything is there in place.

Thanks for your review.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.