[Bug 722791] basesrc: not respecting seqnum of eos from send_event

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722791
  GStreamer | gstreamer (core) | 1.2.2

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267011|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-23 09:04:54 UTC ---
Review of attachment 267011:
 --> (https://bugzilla.gnome.org/review?bug=722791&attachment=267011)

The seqnum should be the one of the segment, and as such of the seek that
happened before. Check the design docs about seqnums, I think this approach is
wrong according to the docs.

::: libs/gst/base/gstbasesrc.c
@@ +231,3 @@

+  /* seqnum of the EOS if pending (atomic) */
+  guint pending_eos;

0 is a valid seqnum

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.