[Bug 722791] basesrc: not respecting seqnum of eos from send_event

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722791
  GStreamer | gstreamer (core) | 1.2.2

--- Comment #3 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2014-01-23 14:58:15 UTC ---
(In reply to comment #2)
> Review of attachment 267011 [details]:
> 
> The seqnum should be the one of the segment, and as such of the seek that
> happened before. Check the design docs about seqnums, I think this approach is
> wrong according to the docs.

Should the seqnum for the EOS always be the same of the segment even when there
was no seek?

If so, this should be NOTABUG, right?

> 
> ::: libs/gst/base/gstbasesrc.c
> @@ +231,3 @@
> 
> +  /* seqnum of the EOS if pending (atomic) */
> +  guint pending_eos;
> 
> 0 is a valid seqnum

true, got confused with g_atomic_int_add

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.