[Bug 721715] h264parse: Multiple SEI messages in SEI RBSP

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721715
  GStreamer | gst-plugins-bad | 1.2.2

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267061|none                        |reviewed
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-23 17:15:52 UTC ---
Review of attachment 267061:
 --> (https://bugzilla.gnome.org/review?bug=721715&attachment=267061)

Well, the other patch is good for 1.2 :)

Generally looks good but:

::: gst-libs/gst/codecparsers/gsth264parser.c
@@ +280,3 @@
+  }
+
+  nr->bits_in_cache = 0;

Isn't this skipping only to the next byte if byte-aligned... and otherwise skip
to the *previous* byte?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.