[Bug 721715] h264parse: Multiple SEI messages in SEI RBSP

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721715
  GStreamer | gst-plugins-bad | 1.2.2

--- Comment #13 from Aurélien Zanelli <aurelien.zanelli at parrot.com> 2014-01-23 18:06:42 UTC ---
(In reply to comment #12)
> Review of attachment 267061 [details]:
> 
> Well, the other patch is good for 1.2 :)
> 
> Generally looks good but:
> 
> ::: gst-libs/gst/codecparsers/gsth264parser.c
> @@ +280,3 @@
> +  }
> +
> +  nr->bits_in_cache = 0;
> 
> Isn't this skipping only to the next byte if byte-aligned... and otherwise skip
> to the *previous* byte?

I think no because nal_reader_read() increments its 'byte cursor' after reading
a byte and it 'copies' the byte read to the cache. So set the bits_in_cache to
0 will force nal_reader_read() to read the next byte. 

I don't know if i'm clear, if not, don't hesitate to ask.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.