[Bug 722760] Add VP8 parser in codecparsers submodule

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722760
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267110|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-24 09:12:43 UTC ---
Review of attachment 267110:
 --> (https://bugzilla.gnome.org/review?bug=722760&attachment=267110)

::: gst-libs/gst/codecparsers/gstvp8parser.c
@@ +650,3 @@
+GstVp8ParseResult
+gst_vp8_parse_frame_header (GstVp8FrameHdr * frame_hdr, const guint8 * data,
+    guint offset, gsize size)

Can we get the size of a frame too? Or do we depend on already properly framed
data? Should be documented

::: gst-libs/gst/codecparsers/gstvp8parser.h
@@ +55,3 @@
+  GST_VP8_PARSER_NO_PACKET,
+  GST_VP8_PARSER_NO_PACKET_END,
+  GST_VP8_PARSER_ERROR,

Should we have these other enum values if only OK and ERROR can happen? Will
the others be returned at a later point?

::: gst-libs/gst/codecparsers/gstvp8rangedecoder.c
@@ +175,3 @@
+ * @rd: the #GstRangeDecoder to read
+ *
+ *decode one bit basing on even probability (0x80)

Space missing

::: gst-libs/gst/codecparsers/gstvp8rangedecoder.h
@@ +53,3 @@
+
+gboolean
+gst_vp8_range_decoder_init (GstRangeDecoder * rd, const guint8 * buffer,

Namespace pollution. GstVp8RangeDecoder

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.