[Bug 722760] Add VP8 parser in codecparsers submodule

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722760
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267111|none                        |reviewed
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-24 09:14:53 UTC ---
Review of attachment 267111:
 --> (https://bugzilla.gnome.org/review?bug=722760&attachment=267111)

::: tests/check/libs/vp8parser.c
@@ +82,3 @@
+};
+
+GST_START_TEST (test_vp8_parse)

Maybe add a test for non-keyframes too

@@ +91,3 @@
+
+  assert_equals_int (gst_vp8_parse_frame_header (&frame_hdr, vp8_frame_data,
0,
+    sizeof (vp8_frame_data)/sizeof (guint8)), GST_VP8_PARSER_OK);

sizeof(guint8) is always 1

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.