[Bug 732741] camerabin2: Fails reconfiguring the source

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Jul 11 07:43:39 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=732741
  GStreamer | gst-plugins-bad | 1.3.90

--- Comment #13 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-07-11 14:43:36 UTC ---
Created an attachment (id=280514)
 View: https://bugzilla.gnome.org/attachment.cgi?id=280514
 Review: https://bugzilla.gnome.org/review?bug=732741&attachment=280514

[PATCH] wrappercamerabinsrc: Fix caps filter caps proxying


The notify signal is triggered when caps is changed. But instead of
proxying the fixed caps, we query for the caps. Hence, when we go to
READY state, we endup setting template caps on the proxied caps
filter instead of NULL, which leads to negoitation failure. Correctly
proxy NULL caps if this is the new caps. Fixes not negotiated error
when running in cheese. Also fix a leak of caps string in one of the
trace.

https://bugzilla.gnome.org/show_bug.cgi?id=732741
---
 gst/camerabin2/gstwrappercamerabinsrc.c | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list