[Bug 732741] camerabin2: Fails reconfiguring the source

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Jul 11 09:13:04 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=732741
  GStreamer | gst-plugins-bad | 1.3.90

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #280514|none                        |committed
             status|                            |

--- Comment #14 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-07-11 16:13:01 UTC ---
(From update of attachment 280514)
Reviewed by Thiago, a small change, I do if (caps) unref (caps) instead of
replace.

commit 362951b9ec7139da43b0a72b6b80c06a67d05b04
Author: Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>
Date:   Fri Jul 11 10:40:42 2014 -0400

    wrappercamerabinsrc: Fix caps filter caps proxying

    The notify signal is triggered when caps is changed. But instead of
    proxying the fixed caps, we query for the caps. Hence, when we go to
    READY state, we endup setting template caps on the proxied caps
    filter instead of NULL, which leads to negoitation failure. Correctly
    proxy NULL caps if this is the new caps. Fixes not negotiated error
    when running in cheese. Also fix a leak of caps string in one of the
    trace.

    https://bugzilla.gnome.org/show_bug.cgi?id=732741

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list