[Bug 733788] QtGStreamer on Windows

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733788
  GStreamer | qt-gstreamer | 1.2.0

George Kiagiadakis <george.kiagiadakis> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george.kiagiadakis at collabor
                   |                            |a.com

--- Comment #1 from George Kiagiadakis <george.kiagiadakis at collabora.com> 2014-07-27 08:16:57 UTC ---
(In reply to comment #0)
>  1. I had to delete the header file <Memory>, as this conflicted with the CRT's
> <memory>, due to Windows being case insensitive.

This sucks. This is not acceptable as a patch for QtGStreamer in general, so
there needs to be another solution.

One possible solution would be to stop creating manually the camel-case headers
and generate them from cmake *after* the build, just for installing them. That
would need some trickery, though, to get the examples and tests working in-tree
(they should not use the lower-case headers).

>  2. In gstqtglvideosinkbase, I renamed a local variable from interface to iface
> to avoid a compile error.

I don't see why this would be an error, but the patch doesn't hurt. I can
commit that part.

>  3. I added an option in cmake to set the CMAKE_LIBRARY_PATH so that the path
> to the Windows SDK can be specified in the CMake-GUI.

This doesn't belong in QtGStreamer imho. CMAKE_LIBRARY_PATH is a standard cmake
option, like CMAKE_PREFIX_PATH and others. If you would like to have it in
cmake gui, then perhaps you could file a feature request for cmake. Typically
this is specified on the command line, either as an environment variable or as
a cmake variable.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.