[Bug 733788] QtGStreamer on Windows

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733788
  GStreamer | qt-gstreamer | 1.2.0

--- Comment #2 from Chris <csbgz at icloud.com> 2014-07-27 10:04:00 UTC ---
(In reply to comment #1)
> One possible solution would be to stop creating manually the camel-case headers
> and generate them from cmake *after* the build, just for installing them. That
> would need some trickery, though, to get the examples and tests working in-tree
> (they should not use the lower-case headers).

Another way might be to move the camel-case headers to a separate directory in
the tree, such that even within the tree they always have to be referred to by
their fully qualified name i.e. <QGst/Memory>, in that example. What do you
think?

> >  2. In gstqtglvideosinkbase, I renamed a local variable from interface to iface
> > to avoid a compile error.
> 
> I don't see why this would be an error, but the patch doesn't hurt. I can
> commit that part.

Thanks. Some compiler options on windows make 'interface' a reserved word,
though I'm surprised that the build is using any of these options. I didn't
investigate in detail as the fix was quick and obvious. I can look again later,
once we've solved the naming conflict with the memory header file.

> This doesn't belong in QtGStreamer imho. CMAKE_LIBRARY_PATH is a standard cmake
> option, like CMAKE_PREFIX_PATH and others. If you would like to have it in
> cmake gui, then perhaps you could file a feature request for cmake. Typically
> this is specified on the command line, either as an environment variable or as
> a cmake variable.

Yes, agreed, there are other ways of achieving the same thing.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.