[Bug 726861] srtp: add support for rollover counter

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726861
  GStreamer | gst-plugins-bad | git

--- Comment #9 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2014-06-03 19:54:27 UTC ---
Review of attachment 276946:
 --> (https://bugzilla.gnome.org/review?bug=726861&attachment=276946)

::: ext/srtp/gstsrtpdec.c
@@ +1062,3 @@
+        /* We finally add the RTP sequence number to the current
+         * rollover counter. */
+        stream->rtp_rdbx.index |= seqnum;

I wonder if this shouldn't be something like
stream->rtp_rdbx.index &= ~0xFFFF;
stream->rtp_rdbx.index |= seqnum;

Or are we always certain that this happens immediately after the roc has been
reset ? Just using the bitwise or on it's own worries me a bit.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.