[Bug 726861] srtp: add support for rollover counter

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726861
  GStreamer | gst-plugins-bad | git

--- Comment #10 from Aleix Conchillo Flaqué <aleix at oblong.com> 2014-06-03 20:01:37 UTC ---
(In reply to comment #9)
> Review of attachment 276946 [details]:
> 
> ::: ext/srtp/gstsrtpdec.c
> @@ +1062,3 @@
> +        /* We finally add the RTP sequence number to the current
> +         * rollover counter. */
> +        stream->rtp_rdbx.index |= seqnum;
> 
> I wonder if this shouldn't be something like
> stream->rtp_rdbx.index &= ~0xFFFF;
> stream->rtp_rdbx.index |= seqnum;
> 
> Or are we always certain that this happens immediately after the roc has been
> reset ? Just using the bitwise or on it's own worries me a bit.

Good point. I think it's safer to do what you suggest.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.