[Bug 725167] opusdec PLC doesn't seem to work as well as Chrome

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Jun 3 13:04:52 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=725167
  GStreamer | gst-plugins-bad | 1.2.1

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #276871|none                        |needs-work
             status|                            |

--- Comment #15 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2014-06-03 20:04:45 UTC ---
Review of attachment 276871:
 --> (https://bugzilla.gnome.org/review?bug=725167&attachment=276871)

::: gst-libs/gst/audio/gstaudiodecoder.c
@@ +808,2 @@
   /* normalize to bool */
+  dec->priv->agg = !!res;

Please don't make unrelated changes. and run your commits through the commit
hook that uses gst-indent. "! !res" is what gst-indent wants.

@@ +1816,3 @@
+           audio ends (though can make a reasonable guess based on the
presumption
+           of constant ptime) */
+        if (!GST_CLOCK_TIME_IS_VALID (dec->priv->out_ts)) {

You probably don't meant to use "!" here.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list