[Bug 725167] opusdec PLC doesn't seem to work as well as Chrome

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725167
  GStreamer | gst-plugins-bad | 1.2.1

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #276872|none                        |rejected
             status|                            |

--- Comment #16 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2014-06-03 20:17:10 UTC ---
Review of attachment 276872:
 --> (https://bugzilla.gnome.org/review?bug=725167&attachment=276872)

I'm not convinced that this patch is correct, removing the call to
apply_offset() looks quite suspect.

And actually, why do you pass the duration as rtptime and then convert it back
to nanoseconds in the depayloader instead of just using the regular duration
here?

::: gst/rtpmanager/gstrtpjitterbuffer.c
@@ +1507,3 @@
 apply_offset (GstRtpJitterBuffer * jitterbuffer, GstClockTime timestamp)
 {
+  GstClockTime offsetTime = timestamp;

I'm not sure why you just rename the variable here, this is not useful or
needed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.