[Bug 731672] corrupted output with "omxvideodec ! videoconvert ! pngenc"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731672
  GStreamer | gst-omx | 1.2.4

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #278957|none                        |needs-work
             status|                            |

--- Comment #11 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-06-23 01:27:18 UTC ---
Review of attachment 278957:
 --> (https://bugzilla.gnome.org/review?bug=731672&attachment=278957)

::: omx/gstomxbufferpool.c
@@ +290,3 @@
     pool->add_videometa =
         gst_buffer_pool_config_has_option (config,
+        GST_BUFFER_POOL_OPTION_VIDEO_META) == 0;

No, I doubt this is correct. We should add video meta if the option is enabled
(not the opposite). Check where the pool is being configured, and make sure we
do enable this option. Also, in this case we strictly need vieometa, if
downstream don't support that meta we should fail cleanly. Same thing for
encoder, if upstream wants to take the pool, but did not enable the meta, we
should fail somehow.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.