[Bug 731672] corrupted output with "omxvideodec ! videoconvert ! pngenc"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731672
  GStreamer | gst-omx | 1.2.4

--- Comment #12 from Aurélien Zanelli <aurelien.zanelli at parrot.com> 2014-06-23 08:22:21 UTC ---
My previous test did not work because filesink doesn't support video meta.
On 1.3.1, videoscale and videoconvert handle video meta unless they are set in
passthrough mode.

By the way, Nicolas is right, we should only add video meta if the option is
enabled in the pool.

(In reply to comment #11)
> Review of attachment 278957 [details]:
> 
> ::: omx/gstomxbufferpool.c
> @@ +290,3 @@
>      pool->add_videometa =
>          gst_buffer_pool_config_has_option (config,
> +        GST_BUFFER_POOL_OPTION_VIDEO_META) == 0;
> 
> No, I doubt this is correct. We should add video meta if the option is enabled
> (not the opposite).
I agree with that.

> Also, in this case we strictly need vieometa, if
> downstream don't support that meta we should fail cleanly. Same thing for
> encoder, if upstream wants to take the pool, but did not enable the meta, we
> should fail somehow.
If we fail, we won't be able to use filesink or other elements which don't
handle video stride. Maybe, we can rather do something in the decoder, or we
can handle the stride meta in videoscale/videoconvert/... if downstream element
doesn't support even if no other conversion is needed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.