[Bug 732445] aggregator: Many invalid memory access to destroyed GSources in the unit test

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732445
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #279588|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-06-30 10:38:46 UTC ---
Review of attachment 279588:
 --> (https://bugzilla.gnome.org/review?bug=732445&attachment=279588)

See last comment :) And ...

::: gst-libs/gst/base/gstaggregator.c
@@ +501,3 @@
+  source = g_idle_source_new ();
+  g_source_set_callback (source, (GSourceFunc) aggregate_func, self, NULL);
+  priv->gsources = g_list_append (priv->gsources, source);

g_list_prepend() or use a GQueue. But g_list_append() is O(n)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.