[Bug 732445] aggregator: Many invalid memory access to destroyed GSources in the unit test

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=732445
  GStreamer | gst-plugins-bad | git

--- Comment #5 from Thibault Saunier <tsaunier at gnome.org> 2014-06-30 10:39:01 UTC ---
(In reply to comment #2)
> Review of attachment 279587 [details]:
> 
> ::: gst-libs/gst/base/gstaggregator.c
> @@ +382,3 @@
> +_destroy_gsource (GSource * source)
> +{
> +  g_source_destroy (source);
> 
> Don't you additionally have to unref the source? Otherwise looks good

In g_source_attach_unlocked it increases the refcount of the source and in
g_main_context_invoke_full it was g_source_unref ing, so we actually own the
refs at this point.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.