[Bug 721953] pango: basetextoverlay: handle video/x-raw(ANY) if downstream supports the GstVideoOverlayCompositionMeta API

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721953
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267573|accepted-commit_now         |needs-work
             status|                            |

--- Comment #28 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-03-02 20:08:42 UTC ---
Review of attachment 267573:
 --> (https://bugzilla.gnome.org/review?bug=721953&attachment=267573)

Almost ready too

::: tests/check/elements/textoverlay.c
@@ +54,3 @@

+#define VIDEO_CAPS_TEMPLATE_WITH_FEATURE_STRING      \
+    "video/x-raw(meta:GstVideoOverlayComposition), " \

You have a #define for that :)

@@ +111,3 @@
+      gboolean need_pool = FALSE;
+
+      gst_query_parse_allocation (query, &caps, &need_pool);

You don't need to call this here if you don't use the results anyway

@@ +476,3 @@
 GST_END_TEST;

+GST_START_TEST (test_video_passthrough_with_feature)

What this should test if *unsupported* caps are working
if the comp meta is supported. E.g. put video/x-raw(memory:EGLImage)
there or some arbitrary video/x-raw,format=ABCD

However that test here as is, is also a bit useful. So keep it
around and just add a new one :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.