[Bug 725341] playbin: detect if video-sink supports deinterlacing

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725341
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270505|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-03-02 20:13:25 UTC ---
Review of attachment 270505:
 --> (https://bugzilla.gnome.org/review?bug=725341&attachment=270505)

No idea about the subtitle overlay part here. That would currently be a bit
annoying to handle as we can't easily get here from the sink if it does support
overlay composition or not, and also don't know if the subtitle renderer
supports it. Needs some more thoughts. Same goes for rescaling btw, but I would
say it's save to assume that any sink that can do deinterlacing can also do
scaling ;)

But otherwise this is how it is supposed to be, yes.

::: gst/playback/gstplaysink.c
@@ +1516,3 @@
+  }
+
+  it = gst_bin_iterate_elements (GST_BIN (element));

iterate_recurse() (probably same change needed for the colorbalance stuff).
bins might be nested

@@ +1518,3 @@
+  it = gst_bin_iterate_elements (GST_BIN (element));
+  while (gst_iterator_foreach (it, iterate_deinterlace_elements,
+          &ret) == GST_ITERATOR_RESYNC)

Why not gst_iterator_find_custom()?

@@ +3127,3 @@
+      need_deinterlace =
+          !video_sink_supports_deinterlacing (GST_ELEMENT
+          (playsink->video_sink));

Please make sure that this is reconfigure-safe. Especially if previously we
needed a deinterlace element but now don't, we need to make sure that it is
properly removed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.