[Bug 727306] New: Decklinksrc won't initialize some models of capture cards (Patch included!)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727306
  GStreamer | gst-plugins-bad | git

           Summary: Decklinksrc won't initialize some models of capture
                    cards (Patch included!)
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: isaac at isrv.pw
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


When initializing devices in decklink.cpp, for some reason the code would
return immediately if it can't get an input or output interface on the card.
While this isn't a problem for most Blackmagic cards, two models only have an
input or an output interface, causing certain interfaces not to be grabbed.
This fixes bug #725175 as well. 

diff --git a/sys/decklink/gstdecklink.cpp b/sys/decklink/gstdecklink.cpp
index 848ff28..067665e 100644
--- a/sys/decklink/gstdecklink.cpp
+++ b/sys/decklink/gstdecklink.cpp
@@ -228,21 +228,18 @@ init_devices (void)
         (void **) &devices[i].input);
     if (ret != S_OK) {
       GST_WARNING ("selected device does not have input interface");
-      return;
     }

     ret = decklink->QueryInterface (IID_IDeckLinkOutput,
         (void **) &devices[i].output);
     if (ret != S_OK) {
       GST_WARNING ("selected device does not have output interface");
-      return;
     }

     ret = decklink->QueryInterface (IID_IDeckLinkConfiguration,
         (void **) &devices[i].config);
     if (ret != S_OK) {
       GST_WARNING ("selected device does not have config interface");
-      return;
     }

     ret = iterator->Next (&decklink);

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.