[Bug 727306] Decklinksrc won't initialize some models of capture cards (Patch included!)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727306
  GStreamer | gst-plugins-bad | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |nicolas.dufresne at collabora.
                   |                            |co.uk
     Ever Confirmed|0                           |1

--- Comment #1 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-03-29 19:36:38 UTC ---
That's seems fair, but incomplete. decklinksrc seems to care about input and
config, decklinksink only cares about output (seems twisted, but I'm not
surprised after having worked with V4L2).

The reason it's incomplete, is that both sink and src assume these will be
present, calling a function on the returned structure, leading to crash. To
make it worst, this structure is not initialized from what I see (though this
is C++, I might be wrong).

So I would say, unless C++ make this safe, memset to 0 the array of Devices,
and add required NULL check / failure in src and sink element. This way it can
cleanly fail is the element is setup wrongly. Also, when done, commit your
changes with your real name and email address into you local git repo (git
master), and use git format-patch -1 to create a file we can merge using git
am. We can deal with the backporting to 1.2, this element havent changed much.

Thanks for your time and contribution.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.