[Bug 729882] opusenc: use aux vars to minimize critical region

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat May 10 08:36:25 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=729882
  GStreamer | gst-plugins-bad | 1.2.4

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #276285|none                        |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-10 15:36:20 UTC ---
Review of attachment 276285:
 --> (https://bugzilla.gnome.org/review?bug=729882&attachment=276285)

::: ext/opus/gstopusenc.c
@@ +845,3 @@
+      frame_samples, omap.data, max_payload_size * enc->n_channels);
+
+  g_mutex_unlock (&enc->property_lock);

If I'm not mistaken you can unlock already right before "buf" is mapped

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list