[Bug 729882] opusenc: use aux vars to minimize critical region
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Sat May 10 08:42:12 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=729882
GStreamer | gst-plugins-bad | 1.2.4
--- Comment #7 from Miguel París Díaz <mparisdiaz at gmail.com> 2014-05-10 15:42:10 UTC ---
Review of attachment 276285:
--> (https://bugzilla.gnome.org/review?bug=729882&attachment=276285)
::: ext/opus/gstopusenc.c
@@ +845,3 @@
+ frame_samples, omap.data, max_payload_size * enc->n_channels);
+
+ g_mutex_unlock (&enc->property_lock);
It was done in the previous patch, and I have had to change it because
opus_multistream_encode uses enc->state and it can be destroyed before use it
in this function.
So we must unlock here.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list