[Bug 709224] audio/videodecoder: Not returning GST_FLOW_EOS when after segment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709224
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277086|none                        |reviewed
             status|                            |

--- Comment #63 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-24 07:47:52 UTC ---
Review of attachment 277086:
 --> (https://bugzilla.gnome.org/review?bug=709224&attachment=277086)

::: gst/gstpad.c
@@ +392,3 @@
   pad->priv->events_cookie = 0;
   pad->priv->last_cookie = -1;
+  pad->priv->last_flowret = GST_FLOW_OK;

I think initially it should be GST_FLOW_FLUSHING until the pad is activated...
and GST_FLOW_FLUSHING again when it's deactivated. Otherwise good, just see the
locking comment.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.